Document phoenix.baseUrl in config.sample.php#36007
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36007 +/- ##
=======================================
Coverage 53.85% 53.85%
=======================================
Files 63 63
Lines 7377 7377
Branches 1301 1301
=======================================
Hits 3973 3973
Misses 3019 3019
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #36007 +/- ##
=======================================
Coverage 53.85% 53.85%
=======================================
Files 63 63
Lines 7377 7377
Branches 1301 1301
=======================================
Hits 3973 3973
Misses 3019 3019
Partials 385 385
Continue to review full report at Codecov.
|
|
|
||
| /** | ||
| * If phoenix.baseUrl is set public and private links will be redirected to this | ||
| * url. Phoenix will handle these links accordingly. |
There was a problem hiding this comment.
But only if the Phoenix App is loaded and enabled...
(Additional, add a comma for better readability: is set public --> is set, public)
Maybe to tell why this is necessary ? A brief reason would help.
There was a problem hiding this comment.
But only if the Phoenix App is loaded and enabled...
Phoenix can operate independent from owncloud - there is no need in having it installed as an app
There was a problem hiding this comment.
confusing, as there is an app on the marketplace...
There was a problem hiding this comment.
To be precise:
- phoenix can be installed as an owncloud app
- phoenix can be installed on any web space (basically when installed as an app nothing else then serving the web assets is done by owncloud/apache)
DeepDiver1975
force-pushed
the
bugfix/add-phoenix-base-ur-to-config.sample
branch
from
0158c31 to
c101868
Compare
| * If phoenix.baseUrl is set, public and private links will be redirected to this | ||
| * url. Phoenix will handle these links accordingly. | ||
| * | ||
| * As an example, in case 'phoenix.baseUrl' is set to 'http://phoenix,example.com, |
There was a problem hiding this comment.
The URL needs a trailing single quote.
settermjd
left a comment
settermjd
left a comment
There was a problem hiding this comment.
Other than the missing, trailing, single quote, it looks good to me.
DeepDiver1975
force-pushed
the
bugfix/add-phoenix-base-ur-to-config.sample
branch
from
c101868 to
ba815fa
Compare
delete-merged-branch
Bot
deleted the
bugfix/add-phoenix-base-ur-to-config.sample
branch
4 participants
Description
The new config parameter phoenix.baseUrl is now documented in config.sample.php
Related Issue
Types of changes
Checklist:
Open tasks: